Bug 22733 – Temp file layout tests fail on Linux

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dean McNamee]

LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html
LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html
LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html

For example, these tests fail due to a platform difference in their use of the builtin PHP sys_get_temp_dir.  See the comments at:

http://us.php.net/sys_get_temp_dir

"""This function does not always add trailing slash. This behaviour is inconsistent across systems, so you have keep an eye on it."""

When running layout tests on Linux, sys_get_temp_dir does not return a trailing slash.  We can see an example of the failure via strace:

[pid 13932] open("/tmppreflightCacheTimeout.txt", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = -1 EACCES (Permission denied)

The solution is just to always append a trailing slash, on some platforms this might result in /tmp//blah, but that shouldn't be a problem.

[Dean McNamee]

Created attachment 25838 [details]
Patch to always append / after the temp directory.

[Dean McNamee]

I realized I forgot a ChangeLog, if the patch looks ok I'll add one.

[Darin Adler]

Comment on attachment 25838 [details]
Patch to always append / after the temp directory.

Seems like a fine change. But this patch lacks a ChangeLog entry. That makes extra work for the committer. So please submit a new patch with the ChangeLog entry.

[Dean McNamee]

Created attachment 25844 [details]
Now with a changelog.

[Dean McNamee]

Created attachment 25845 [details]
Now with a changelog.

[Dean McNamee]

Thanks for the review.  I don't have commit access, so it would be great for someone to commit it for me.

[Holger Freyther]

Landed in r39202.