Bug 227328 - Base Options::useWebAssemblyFastMemory's default value on Gigacage::hasCapacityToUseLargeGigacage.
Summary: Base Options::useWebAssemblyFastMemory's default value on Gigacage::hasCapaci...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-23 16:09 PDT by Mark Lam
Modified: 2021-06-23 21:28 PDT (History)
9 users (show)

See Also:


Attachments
proposed patch. (6.36 KB, patch)
2021-06-23 16:17 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (6.58 KB, patch)
2021-06-23 16:18 PDT, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-06-23 16:09:58 PDT
Gigacage::hasCapacityToUseLargeGigacage is determined based on EFFECTIVE_ADDRESS_WIDTH.  If we have enough address range to potentially use a large gigacage, then we have enough address range to useWebAssemblyFastMemory.
Comment 1 Mark Lam 2021-06-23 16:17:04 PDT
Created attachment 432103 [details]
proposed patch.
Comment 2 Mark Lam 2021-06-23 16:18:40 PDT
Created attachment 432104 [details]
proposed patch.
Comment 3 Mark Lam 2021-06-23 21:27:59 PDT
Thanks for the review.  Landed in r279209: <http://trac.webkit.org/r279209>.
Comment 4 Radar WebKit Bug Importer 2021-06-23 21:28:19 PDT
<rdar://problem/79708581>