We end up duplicating quite a bit of code which creates and deletes a temporary directory during unit testing. It's pretty easy to build a shared TestCase class which reduces our duplicated code.
<rdar://problem/79697909>
Created attachment 432101 [details] Patch
Created attachment 432391 [details] Patch
Comment on attachment 432391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432391&action=review > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/unittest.py:29 > +from unittest import TestCase whats the value in overriding the name? I think importing unitest and something like webkitunittest would be a lot clearer.
(In reply to Stephanie Lewis from comment #4) > Comment on attachment 432391 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=432391&action=review > > > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/unittest.py:29 > > +from unittest import TestCase > > whats the value in overriding the name? I think importing unitest and > something like webkitunittest would be a lot clearer. Mostly because then something importing it would be `from webkitcorepy.webkitunittest import <class>` which seemed redundant to me...would `from webkitcorepy.testing` be better?
Created attachment 432407 [details] Patch
Created attachment 432411 [details] Patch for landing
Committed r279347 (239215@main): <https://commits.webkit.org/239215@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432411 [details].