Bug 227254 - Unskip arguments-properties-order.js on arm and mips
Summary: Unskip arguments-properties-order.js on arm and mips
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-22 07:59 PDT by Mikhail R. Gadelha
Modified: 2021-06-24 04:44 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.17 KB, patch)
2021-06-22 08:01 PDT, Mikhail R. Gadelha 		no flags Details | Formatted Diff | Diff
Patch (1.22 KB, patch)
2021-06-23 07:28 PDT, Mikhail R. Gadelha 		no flags Details | Formatted Diff | Diff
Patch (1.21 KB, patch)
2021-06-23 08:48 PDT, Mikhail R. Gadelha 		no flags Details | Formatted Diff | Diff
Patch (1.21 KB, patch)
2021-06-23 08:49 PDT, Mikhail R. Gadelha 		no flags Details | Formatted Diff | Diff
Patch (1.21 KB, patch)
2021-06-23 08:55 PDT, Mikhail R. Gadelha 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail R. Gadelha 2021-06-22 07:59:28 PDT 
Unskip arguments-properties-order.js on arm and mips
Comment 1 Mikhail R. Gadelha 2021-06-22 08:01:15 PDT 
Created attachment 431965 [details]
Patch
Comment 2 Angelos Oikonomopoulos 2021-06-23 06:43:27 PDT 
The ChangeLog claims the patch will unskip the test "on arm and mips", but the test is only skipped on mips.

What's more, as the preceding comment mentions, the issue is that the test fails on the Loongson 3A4000, which is currently assigned to the igalia-jsc32-mipsel-ews-02 worker (that's where the EWS run executed, good!) along with two ci20 boards.

However there's no guarantee that the test ran on the loongson instead of the ci20 boards. If you can (manually) test on the loongson (a.k.a. "the lemote box") that'd be great!
Comment 3 Mikhail R. Gadelha 2021-06-23 07:28:08 PDT 
Created attachment 432038 [details]
Patch
Comment 4 Mikhail R. Gadelha 2021-06-23 07:31:09 PDT 
Tested on Loongson with 50 iterations and no crash.

Also removed the comment.
Comment 5 Mikhail R. Gadelha 2021-06-23 08:48:48 PDT 
Created attachment 432051 [details]
Patch
Comment 6 Mikhail R. Gadelha 2021-06-23 08:49:50 PDT 
Created attachment 432053 [details]
Patch
Comment 7 Mikhail R. Gadelha 2021-06-23 08:55:16 PDT 
Created attachment 432056 [details]
Patch
Comment 8 EWS 2021-06-24 04:44:00 PDT 
Committed r279219 (239105@main): <https://commits.webkit.org/239105@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432056 [details].
Comment 9 Radar WebKit Bug Importer 2021-06-24 04:44:18 PDT 
<rdar://problem/79720109>