Sometimes the IOSurface sent for WebXR is a MTLSharedTexture, which means it can't be treated like a regular single-plane IOSurface. Using the fix for 226690, we should be able to create a MTLTexture object from the IOSurface and bind that to a GL texture.
<rdar://problem/79591620>
Created attachment 431940 [details] Patch
Comment on attachment 431940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431940&action=review > Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:143 > + auto size = data.surface->size(); Should we still do the size check for the single plane IOSurface case? > Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:198 > + gCGL->destroyPbufferAndDetachIOSurface(m_ioSurfaceTextureHandle); Should we set m_ioSurfaceTextureHandle to null and m_ioSurfaceTextureHandleIsShared to false after?
Comment on attachment 431940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431940&action=review >> Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:143 >> + auto size = data.surface->size(); > > Should we still do the size check for the single plane IOSurface case? Yeah - good point. I'll put it back in. >> Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:198 >> + gCGL->destroyPbufferAndDetachIOSurface(m_ioSurfaceTextureHandle); > > Should we set m_ioSurfaceTextureHandle to null and m_ioSurfaceTextureHandleIsShared to false after? Agreed. Ultimately we should have a class that wraps these handles and calls the correct destroyer. I started on that but got annoyed that I'd have to keep a reference to the GraphicsContextGL as well as the handle.
Created attachment 432288 [details] EWS test
Created attachment 432289 [details] EWS test 2
Committed r279298 (239174@main): <https://commits.webkit.org/239174@main>