It should just a static function.
Created attachment 431799 [details] Patch
Comment on attachment 431799 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431799&action=review > Source/WebCore/ChangeLog:7 > + Please add a short why here. > Source/WebCore/rendering/HitTestLocation.cpp:29 > + IntPoint actualPoint(flooredIntPoint(point)); Could be slightly nicer by using assignment + auto to avoid stating IntPoint twice. (I do realize you are just moving it, but still). > Source/WebCore/rendering/HitTestLocation.cpp:37 > + return IntRect(actualPoint, actualPadding); This could probably just be return { actualPoint, actualPadding };
(In reply to Sam Weinig from comment #2) > Comment on attachment 431799 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431799&action=review > > > Source/WebCore/ChangeLog:7 > > + > > Please add a short why here. > > > Source/WebCore/rendering/HitTestLocation.cpp:29 > > + IntPoint actualPoint(flooredIntPoint(point)); > > Could be slightly nicer by using assignment + auto to avoid stating IntPoint > twice. (I do realize you are just moving it, but still). > > > Source/WebCore/rendering/HitTestLocation.cpp:37 > > + return IntRect(actualPoint, actualPadding); > > This could probably just be return { actualPoint, actualPadding }; I see these change in a subsequent patch, so feel free to ignore.
Created attachment 431822 [details] Patch
Committed r279057 (238977@main): <https://commits.webkit.org/238977@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431822 [details].
<rdar://problem/79540449>