Bug 227172 – [GLIB] REGRESSION(r278701): numerous WebRTC tests failing after libwebrtc update to M92

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Arcady Goldmints-Orlov]

The change in r278564 which updated libvpx has caused a number of WebRTC tests to start either failing or timing out on both GTK and WPE.

[Arcady Goldmints-Orlov]

Created attachment 431787 [details]
Patch

[Philippe Normand]

The culprit is the libwebrtc update, see for instance: https://results.webkit.org/?suite=layout-tests&test=webrtc/datachannel/basic.html

[Philippe Normand]

Comment on attachment 431787 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431787&action=review

Thanks for spotting this issue, Arcady. I found the problem, our port had data channel support disabled by mistake during the libwebrtc massive update... I have a patch fixing it, I'll likely land it unreviewed (2 lines added in a cmake file...)

> LayoutTests/platform/glib/TestExpectations:1094
> -webkit.org/b/191006 webrtc/simulcast-h264.html [ Failure ]
> +webkit.org/b/191006 webrtc/simulcast-h264.html [ Timeout ]

The new bug should be added:

webkit.org/b/227172 webkit.org/b/191006 webrtc/simulcast-h264.html [ Timeout ]

> LayoutTests/platform/glib/TestExpectations:1161
> +webkit.org/b/227172 inspector/page/overrideSetting-ICECandidateFilteringEnabled.html [ Skip ]

Skip should be for features not implemented by our ports.

[Philippe Normand]

There's libvpx breakage as well indeed :( The libvpx included in the SDK is now too old for the ABI libwebrtc expects...

[Philippe Normand]

Created attachment 431795 [details]
Patch

[Philippe Normand]

EWS won't pass until SDK update in bug 227176 is deployed.

[Philippe Normand]

Created attachment 431837 [details]
Patch

[EWS]

Committed r279065 (238985@main): <https://commits.webkit.org/238985@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431837 [details].

[Radar WebKit Bug Importer]

<rdar://problem/79554664>

[Carlos Alberto Lopez Perez]

*** Bug 227233 has been marked as a duplicate of this bug. ***