Bug 227172 - [GLIB] REGRESSION(r278701): numerous WebRTC tests failing after libwebrtc update to M92
Summary: [GLIB] REGRESSION(r278701): numerous WebRTC tests failing after libwebrtc upd...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Linux
: P2 Normal
Assignee: Philippe Normand
Keywords: InRadar
: 227233 (view as bug list)
Depends on: 227176
  Show dependency treegraph
Reported: 2021-06-18 10:59 PDT by Arcady Goldmints-Orlov
Modified: 2021-06-21 18:57 PDT (History)
11 users (show)

See Also:

Patch (6.21 KB, patch)
2021-06-18 13:52 PDT, Arcady Goldmints-Orlov
no flags Details | Formatted Diff | Diff
Patch (2.45 KB, patch)
2021-06-19 09:15 PDT, Philippe Normand
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.45 KB, patch)
2021-06-21 01:37 PDT, Philippe Normand
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arcady Goldmints-Orlov 2021-06-18 10:59:18 PDT
The change in r278564 which updated libvpx has caused a number of WebRTC tests to start either failing or timing out on both GTK and WPE.
Comment 1 Arcady Goldmints-Orlov 2021-06-18 13:52:06 PDT
Created attachment 431787 [details]
Comment 2 Philippe Normand 2021-06-19 01:25:24 PDT
The culprit is the libwebrtc update, see for instance: https://results.webkit.org/?suite=layout-tests&test=webrtc/datachannel/basic.html
Comment 3 Philippe Normand 2021-06-19 01:45:53 PDT
Comment on attachment 431787 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=431787&action=review

Thanks for spotting this issue, Arcady. I found the problem, our port had data channel support disabled by mistake during the libwebrtc massive update... I have a patch fixing it, I'll likely land it unreviewed (2 lines added in a cmake file...)

> LayoutTests/platform/glib/TestExpectations:1094
> -webkit.org/b/191006 webrtc/simulcast-h264.html [ Failure ]
> +webkit.org/b/191006 webrtc/simulcast-h264.html [ Timeout ]

The new bug should be added:

webkit.org/b/227172 webkit.org/b/191006 webrtc/simulcast-h264.html [ Timeout ]

> LayoutTests/platform/glib/TestExpectations:1161
> +webkit.org/b/227172 inspector/page/overrideSetting-ICECandidateFilteringEnabled.html [ Skip ]

Skip should be for features not implemented by our ports.
Comment 4 Philippe Normand 2021-06-19 03:10:02 PDT
There's libvpx breakage as well indeed :( The libvpx included in the SDK is now too old for the ABI libwebrtc expects...
Comment 5 Philippe Normand 2021-06-19 09:15:44 PDT
Created attachment 431795 [details]
Comment 6 Philippe Normand 2021-06-19 09:16:15 PDT
EWS won't pass until SDK update in bug 227176 is deployed.
Comment 7 Philippe Normand 2021-06-21 01:37:20 PDT
Created attachment 431837 [details]
Comment 8 EWS 2021-06-21 03:13:34 PDT
Committed r279065 (238985@main): <https://commits.webkit.org/238985@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431837 [details].
Comment 9 Radar WebKit Bug Importer 2021-06-21 03:14:36 PDT
Comment 10 Carlos Alberto Lopez Perez 2021-06-21 18:57:42 PDT
*** Bug 227233 has been marked as a duplicate of this bug. ***