Bug 227167 – [css-grid] Use correct block-size to resolve min-content

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

The following WPT test fails -

css/css-grid/grid-items/grid-item-inline-contribution-001.html

Created attachment 431773 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Created attachment 431857 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/79775068>

[Javier Fernandez]

Comment on attachment 431857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431857&action=review

You are adding a TestExpectation Fail entry with the bug this patch tries to fix.

> LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-inline-contribution-001-expected.xht:5
> +  <link rel="author" title="Gérard Talbot" href="http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" />

Encoding issue.

Created attachment 433498 [details]
Patch

[Javier Fernandez]

Comment on attachment 433498 [details]
Patch

r=me

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 433498 [details] to trunk.
Please resolve the conflicts and upload a new patch.

Created attachment 433780 [details]
Patch

[EWS]

Committed r280023 (239765@main): <https://commits.webkit.org/239765@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433780 [details].

[Simon Fraser (smfr)]

Comment on attachment 433780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433780&action=review

> Source/WebCore/rendering/RenderReplaced.cpp:122
> +    if (replacedContentRect() != oldContentRect)
> +        setPreferredLogicalWidthsDirty(true);

This doesn't seem right at all. Why is a CSS Grid fix in RenderReplaced? Why is this marking layout dirty at the end of layout? Why does replacedContentRect (which is about painting) have anything to do with layout?

Any chance to revert this change? Thank you!