Bug 227155 - jitCompileAndSetHeuristics shouldn't return true when we fail to compile
Summary: jitCompileAndSetHeuristics shouldn't return true when we fail to compile
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-17 16:59 PDT by Saam Barati
Modified: 2021-06-22 10:49 PDT (History)
9 users (show)

See Also:

Attachments
WIP (32.96 KB, patch)
2021-06-17 19:19 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (36.49 KB, patch)
2021-06-21 16:24 PDT, Saam Barati 		tzagallo: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch for landing (36.71 KB, patch)
2021-06-21 16:50 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-06-17 16:59:47 PDT 
...
Comment 1 Saam Barati 2021-06-17 19:19:05 PDT 
Created attachment 431749 [details]
WIP
Comment 2 Saam Barati 2021-06-21 16:24:22 PDT 
Created attachment 431926 [details]
patch
Comment 3 Saam Barati 2021-06-21 16:24:38 PDT 
Comment on attachment 431926 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431926&action=review

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:381
> +    if (codeBlock->jitType() == JITType::BaselineJIT) {

This is the bug fix
Comment 4 Tadeu Zagallo 2021-06-21 16:47:10 PDT 
Comment on attachment 431926 [details]
patch

LGTM, might be worth pointing out in the ChangeLog why the new fuzzer is in this patch.
Comment 5 Saam Barati 2021-06-21 16:50:42 PDT 
Created attachment 431930 [details]
patch for landing
Comment 6 EWS 2021-06-22 10:48:51 PDT 
Committed r279126 (239041@main): <https://commits.webkit.org/239041@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431930 [details].
Comment 7 Radar WebKit Bug Importer 2021-06-22 10:49:21 PDT 
<rdar://problem/79622554>