Bug 227147 – Define MacroAssemblerARM64E::numberOfPACBits based on OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH).

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Also define OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) based on MACH_VM_MAX_ADDRESS for OS(DARWIN).

rdar://78785309

[Mark Lam]

Created attachment 431725 [details]
proposed patch.

[Mark Lam]

Created attachment 431729 [details]
proposed patch.

[Mark Lam]

Created attachment 431731 [details]
proposed patch.

[Saam Barati]

Comment on attachment 431731 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=431731&action=review

> Source/WTF/wtf/CagedPtr.h:48
> +    static constexpr unsigned numberOfPACBits = numberOfPointerBits - OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH);

would be good if we eventually renamed this to "maximumNumberOfAllowedPACBits" or similar

[Mark Lam]

(In reply to Saam Barati from comment #4)
> Comment on attachment 431731 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431731&action=review
> 
> > Source/WTF/wtf/CagedPtr.h:48
> > +    static constexpr unsigned numberOfPACBits = numberOfPointerBits - OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH);
> 
> would be good if we eventually renamed this to
> "maximumNumberOfAllowedPACBits" or similar

I can do that in a follow up patch.

[Mark Lam]

Thanks for the review.  Landed in r279028: <http://trac.webkit.org/r279028>.