Bug 227145 - [iOS] Increase contrast for textfields, checkboxes, and radio buttons
Summary: [iOS] Increase contrast for textfields, checkboxes, and radio buttons
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
Keywords: InRadar
Depends on:
Reported: 2021-06-17 14:27 PDT by James Craig
Modified: 2021-07-09 14:47 PDT (History)
13 users (show)

See Also:

Patch (294.70 KB, patch)
2021-07-08 13:13 PDT, Aditya Keerthi
wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch for landing (294.69 KB, patch)
2021-07-09 11:34 PDT, Aditya Keerthi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2021-06-17 14:27:19 PDT
The textfield issue is being worked out in bug 227135, but the contrast of checkboxes and other controls are still using -apple-system-opaque-fill rather than -apple-system-opaque-separator or another more appropriate and higher contrast system color.
Comment 1 James Craig 2021-06-17 14:28:31 PDT
The extreme low contrast problem was called out today in https://twitter.com/gerireid/status/1405203573269569538
Comment 2 Radar WebKit Bug Importer 2021-06-17 14:31:23 PDT
Comment 3 Aditya Keerthi 2021-07-08 13:13:26 PDT
Created attachment 433160 [details]
Comment 4 Wenson Hsieh 2021-07-09 11:18:46 PDT
Comment on attachment 433160 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=433160&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:2090
> +

Nit - you could probably pull `checkboxRadioBackgroundColor(controlStates, styleColorOptions)` out into a local variable here to avoid writing it out twice.

> Source/WebCore/rendering/RenderThemeIOS.mm:2155
> +        context.setFillColor(checkboxRadioBackgroundColor(controlStates, styleColorOptions));

Comment 5 Aditya Keerthi 2021-07-09 11:34:18 PDT
Created attachment 433229 [details]
Patch for landing
Comment 6 EWS 2021-07-09 14:47:27 PDT
Committed r279795 (239562@main): <https://commits.webkit.org/239562@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433229 [details].