Bug 227092 - IndexedDB prints error log about blob files when there is no error
Summary: IndexedDB prints error log about blob files when there is no error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-16 14:03 PDT by Sihui Liu
Modified: 2021-06-24 10:49 PDT (History)
7 users (show)

See Also:

Attachments
Patch (11.93 KB, patch)
2021-06-16 16:28 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (9.72 KB, patch)
2021-06-16 16:30 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (9.63 KB, patch)
2021-06-24 09:19 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-06-16 14:03:55 PDT 
...
Comment 1 Sihui Liu 2021-06-16 16:28:34 PDT 
Created attachment 431619 [details]
Patch
Comment 2 Sihui Liu 2021-06-16 16:30:53 PDT 
Created attachment 431620 [details]
Patch
Comment 3 Chris Dumez 2021-06-21 10:58:31 PDT 
Comment on attachment 431620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431620&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:132
> +    RetainPtr<StoreBlobMessageHandler> handler = adoptNS([[StoreBlobMessageHandler alloc] init]);

auto

> Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:133
> +    RetainPtr<WKWebViewConfiguration> configuration = adoptNS([[WKWebViewConfiguration alloc] init]);

auto

> Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:135
> +    RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);

auto
Comment 4 Radar WebKit Bug Importer 2021-06-23 14:04:21 PDT 
<rdar://problem/79691682>
Comment 5 Sihui Liu 2021-06-24 09:19:42 PDT 
Created attachment 432172 [details]
Patch for landing
Comment 6 EWS 2021-06-24 10:49:42 PDT 
Committed r279237 (239122@main): <https://commits.webkit.org/239122@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432172 [details].