Bug 227090 - [Win] WTF.ParseInteger and WTF.ParseIntegerAllowingTrailingJunk are failing
Summary: [Win] WTF.ParseInteger and WTF.ParseIntegerAllowingTrailingJunk are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-16 13:19 PDT by Fujii Hironori
Modified: 2021-06-17 18:29 PDT (History)
9 users (show)

See Also:

Attachments
WIP patch (697 bytes, patch)
2021-06-16 13:51 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (3.36 KB, patch)
2021-06-16 14:34 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-06-16 13:19:54 PDT 
[Win] WTF.ParseInteger and WTF.ParseIntegerAllowingTrailingJunk are failing

PS C:\home\webkit\gb> .\WebKitBuild\Debug\bin64\TestWTF.exe --gtest_filter=WTF.ParseInteger*
**FAIL** WTF.ParseInteger

..\..\Tools\TestWebKitAPI\Tests\WTF\StringToIntegerConversion.cpp:43
Expected equality of these values:
  -2147483647 - 1
    Which is: -2147483648
  parseInteger<int>("-2147483648")
    Which is: 8-byte object <CC-CC CC-CC 00-CC CC-CC>

**FAIL** WTF.ParseIntegerAllowingTrailingJunk

..\..\Tools\TestWebKitAPI\Tests\WTF\StringToIntegerConversion.cpp:70
Expected equality of these values:
  -2147483647 - 1
    Which is: -2147483648
  parseIntegerAllowingTrailingJunk<int>("-2147483648")
    Which is: 8-byte object <CC-CC CC-CC 00-CC CC-CC>
Comment 1 Fujii Hironori 2021-06-16 13:51:52 PDT 
Created attachment 431596 [details]
WIP patch
Comment 2 Fujii Hironori 2021-06-16 14:34:45 PDT 
Created attachment 431604 [details]
Patch
Comment 3 Yusuke Suzuki 2021-06-17 17:53:28 PDT 
Comment on attachment 431604 [details]
Patch

r=me
Comment 4 EWS 2021-06-17 18:28:02 PDT 
Committed r279027 (238947@main): <https://commits.webkit.org/238947@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431604 [details].
Comment 5 Radar WebKit Bug Importer 2021-06-17 18:29:30 PDT 
<rdar://problem/79481414>