Bug 227054 - Allow WebXR tests to be run on Mac
Summary: Allow WebXR tests to be run on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-15 16:51 PDT by Ada Chan
Modified: 2021-06-16 13:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (151.88 KB, patch)
2021-06-15 17:14 PDT, Ada Chan 		sam: review+
Details | Formatted Diff | Diff
Patch for landing (151.94 KB, patch)
2021-06-16 12:07 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2021-06-15 16:51:23 PDT 
Allow WebXR tests to be run on Mac
Comment 1 Ada Chan 2021-06-15 17:14:48 PDT 
Created attachment 431501 [details]
Patch
Comment 2 Sam Weinig 2021-06-16 08:52:11 PDT 
Comment on attachment 431501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431501&action=review

> LayoutTests/TestExpectations:4905
> +# WebXR - expected to fail.

What about these are expected to fail?

> LayoutTests/TestExpectations:4917
> +# rdar://79306047
> +http/wpt/webxr/xrSession_ended_by_system.https.html [ Skip ]

This should probably have a bugzilla in addition to the radar.

> LayoutTests/TestExpectations:4920
> +# rdar://79367325
> +imported/w3c/web-platform-tests/webxr/xrWebGLLayer_constructor.https.html [ Skip ]

This should probably have a bugzilla in addition to the radar.
Comment 3 Ada Chan 2021-06-16 11:48:04 PDT 
(In reply to Sam Weinig from comment #2)
> Comment on attachment 431501 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431501&action=review
> 
> > LayoutTests/TestExpectations:4905
> > +# WebXR - expected to fail.
> 
> What about these are expected to fail?

These sections of "skip" follow Dean's earlier attempt to enable these tests (https://trac.webkit.org/changeset/277468/webkit). I haven't gone through each of these tests to narrow down the reason of failure. Maybe a better title to use here is just "currently failing".

> 
> > LayoutTests/TestExpectations:4917
> > +# rdar://79306047
> > +http/wpt/webxr/xrSession_ended_by_system.https.html [ Skip ]
> 
> This should probably have a bugzilla in addition to the radar.
> 
> > LayoutTests/TestExpectations:4920
> > +# rdar://79367325
> > +imported/w3c/web-platform-tests/webxr/xrWebGLLayer_constructor.https.html [ Skip ]
> 
> This should probably have a bugzilla in addition to the radar.

I'll file bugzillas for these also and reference them here.
Comment 4 Ada Chan 2021-06-16 12:07:36 PDT 
Created attachment 431584 [details]
Patch for landing
Comment 5 EWS 2021-06-16 13:51:24 PDT 
Committed r278954 (238883@main): <https://commits.webkit.org/238883@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431584 [details].
Comment 6 Radar WebKit Bug Importer 2021-06-16 13:52:30 PDT 
<rdar://problem/79414472>