Bug 227053 - [GLIB] REGRESSION(r277896): fast/canvas/canvas-imageSmoothingEnabled.html and fast/canvas/canvas-imageSmoothingQuality.html are failing
Summary: [GLIB] REGRESSION(r277896): fast/canvas/canvas-imageSmoothingEnabled.html and...
Status: RESOLVED DUPLICATE of bug 264605
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-15 16:24 PDT by Diego Pino
Modified: 2023-11-12 12:15 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2021-06-15 16:24:57 PDT
r277896 change imageSmoothingQuality default value to 'Low' for all platforms, since that's how defined in the specification.

That change made 2 tests start failing:

  fast/canvas/canvas-imageSmoothingEnabled.html [ Failure ]
  fast/canvas/canvas-imageSmoothingQuality.html [ Failure ]

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/canvas/canvas-imageSmoothingEnabled-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/canvas/canvas-imageSmoothingEnabled-actual.txt
@@ -19,9 +19,9 @@
 PASS left_of_center_pixel.data[1] is 0
 PASS left_of_center_pixel.data[2] is 0
 Test that the image is smoothed when imageSmoothingEnabled is set to true.
-PASS left_of_center_pixel.data[0] !== 0 is true
-PASS left_of_center_pixel.data[1] !== 0 is true
-PASS left_of_center_pixel.data[2] !== 0 is true
+FAIL left_of_center_pixel.data[0] !== 0 should be true. Was false.
+FAIL left_of_center_pixel.data[1] !== 0 should be true. Was false.
+FAIL left_of_center_pixel.data[2] !== 0 should be true. Was false.
 Test that restoring actually changes smoothing and not just the attribute value. We are restoring to a point where imageSmoothingEnabled is set to false.
 PASS left_of_center_pixel.data[0] is 0
 PASS left_of_center_pixel.data[1] is 0

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/canvas/canvas-imageSmoothingQuality-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/canvas/canvas-imageSmoothingQuality-actual.txt
@@ -8,14 +8,14 @@
 PASS mediumContext.imageSmoothingQuality is 'medium'
 PASS highContext.imageSmoothingQuality is 'high'
 
-PASS lowData is not mediumData
+FAIL lowData should not be {"0":0,"1":0,"2":0,"3":128}.
 PASS mediumData is not highData
 PASS lowData is not highData
 
 PASS sampleAlpha(lowData) is >= sampleAlpha(mediumData)
 PASS sampleAlpha(mediumData) is >= sampleAlpha(highData)
 
-FAIL defaultContext.imageSmoothingQuality should be low. Was medium.
+PASS defaultContext.imageSmoothingQuality is 'low'
 
 PASS highContext.imageSmoothingEnabled = false; highContext.imageSmoothingQuality is 'high'
 PASS highContext.imageSmoothingQuality = 'medium'; highContext.imageSmoothingQuality is 'medium'
Comment 1 Fujii Hironori 2023-11-12 12:15:33 PST
Cairo based ports pass the test after 270586@main (bug#264605).

Expected to fail, but passed: (2)
  fast/canvas/canvas-imageSmoothingEnabled.html
  fast/canvas/canvas-imageSmoothingQuality.html

https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=fast%2Fcanvas%2Fcanvas-imageSmoothingQuality.html&test=fast%2Fcanvas%2Fcanvas-imageSmoothingEnabled.html

*** This bug has been marked as a duplicate of bug 264605 ***