Migrate App Privacy Report code from WebKitAdditions
Created attachment 431477 [details] Patch
Comment on attachment 431477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431477&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:341 > NSURLRequest *nsRequest = request.nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody); Seems you should address the FIXME above now. > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:344 > + NSMutableURLRequest *mutableRequest = [[nsRequest mutableCopy] autorelease]; Let's avoid using autorelease if possible.
Created attachment 431509 [details] Patch
I took out the renaming, and just left this as a migration patch for simplicity.
Created attachment 431621 [details] Patch
Comment on attachment 431621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431621&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:60 > +static void processPCMRequest(WebCore::PrivateClickMeasurement::PcmDataCarried, NSMutableURLRequest * _Nonnull); Remove _Nonnull
Created attachment 431691 [details] Patch
Created attachment 431696 [details] Patch
Created attachment 431871 [details] Patch
forgot to unskip tests for open source in the latest patch. Will wait for EWS before landing.
Created attachment 431902 [details] Patch for landing
Never mind, EWS doesn't support these layout tests yet, keeping these skipped in open source. Local runs confirm all tests are passing.
Committed r279083 (239002@main): <https://commits.webkit.org/239002@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431902 [details].
<rdar://problem/79580561>
The correct radar is rdar://74333287
Reverted r279083 for reason: Broke Mac Builds Committed r279120 (239037@main): <https://commits.webkit.org/239037@main>
Created attachment 432071 [details] Patch
(In reply to Kate Cheney from comment #17) > Created attachment 432071 [details] > Patch Checks for #if ENABLE(APP_PRIVACY_REPORT) && HAVE(SYMPTOMS_FRAMEWORK) will avoid breaking the build again. Tested locally that everything is building with no errors.
Committed r279184 (239079@main): <https://commits.webkit.org/239079@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432071 [details].