it's confusing and highly error-prone.
Created attachment 431453 [details] Patch
Looks like we've got one test covering this. Will adjust the patch.
Created attachment 431471 [details] Patch
Comment on attachment 431471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431471&action=review > Source/WebCore/rendering/RenderElement.cpp:189 > + if (rendererTypeOverride.contains(ConstructBlockLevelRendererFor::TableTypes)) > return createRenderer<RenderBlockFlow>(element, WTFMove(style)); Is this entire 'default' block about table types? Seems like it would better to explicitly check for a table display type here?
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 431471 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431471&action=review > > > Source/WebCore/rendering/RenderElement.cpp:189 > > + if (rendererTypeOverride.contains(ConstructBlockLevelRendererFor::TableTypes)) > > return createRenderer<RenderBlockFlow>(element, WTFMove(style)); > > Is this entire 'default' block about table types? Seems like it would better > to explicitly check for a table display type here? Yeah, that's a good idea.
Created attachment 431511 [details] Patch
Committed r278919 (238850@main): <https://commits.webkit.org/238850@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431511 [details].
<rdar://problem/79377750>