Bug 22703 - Ordering of branch operands in MacroAssembler in unnecessarily inconsistent.
Summary: Ordering of branch operands in MacroAssembler in unnecessarily inconsistent.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-05 19:09 PST by Gavin Barraclough
Modified: 2008-12-05 19:25 PST (History)
0 users

See Also:


Attachments
The patch (9.29 KB, patch)
2008-12-05 19:12 PST, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-12-05 19:09:45 PST
je, jg etc take an immediate operand as the second argument, but for the equality branches (je, jne) the immediate operand is the first argument.  This is unnecessarily inconsistent.
Comment 1 Gavin Barraclough 2008-12-05 19:12:19 PST
Created attachment 25805 [details]
The patch
Comment 2 Gavin Barraclough 2008-12-05 19:25:26 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/assembler/MacroAssembler.h
Sending        JavaScriptCore/jit/JIT.cpp
Sending        JavaScriptCore/wrec/WRECGenerator.cpp
Transmitting file data ....
Committed revision 39061.