Bug 227024 - ANGLE Metal gl sync objects do not work in case of listener being needed
Summary: ANGLE Metal gl sync objects do not work in case of listener being needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 222731 226841 227059
  Show dependency treegraph
 
Reported: 2021-06-15 06:37 PDT by Kimmo Kinnunen
Modified: 2021-06-16 10:53 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.62 KB, patch)
2021-06-16 01:29 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (3.62 KB, patch)
2021-06-16 01:29 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-06-15 06:37:31 PDT
ANGLE Metal gl sync objects do not work in case of listener being needed

The MTLSharedEventListener is nil due to sandbox.
Comment 1 Kimmo Kinnunen 2021-06-16 01:29:00 PDT
Created attachment 431525 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-06-16 01:29:54 PDT
Created attachment 431526 [details]
Patch
Comment 3 EWS Watchlist 2021-06-16 01:30:11 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Radar WebKit Bug Importer 2021-06-16 02:13:01 PDT
<rdar://problem/79387276>
Comment 5 Per Arne Vollan 2021-06-16 02:20:51 PDT
Comment on attachment 431526 [details]
Patch

R=me.
Comment 6 EWS 2021-06-16 04:52:11 PDT
Committed r278929 (238860@main): <https://commits.webkit.org/238860@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431526 [details].
Comment 7 Kenneth Russell 2021-06-16 10:53:31 PDT
Nice fix Kimmo! Deep magic.