Bug 227023 - [GLIB] Pass a GTlsCertificate to soup_server_new()
Summary: [GLIB] Pass a GTlsCertificate to soup_server_new()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2021-06-15 05:24 PDT by Carlos Garcia Campos
Modified: 2021-06-17 01:39 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2021-06-15 05:25 PDT, Carlos Garcia Campos 		mcatanzaro: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-06-15 05:24:15 PDT 
Instead of using soup_server_set_ssl_cert_file() that will be removed from libsoup soon.
Comment 1 Carlos Garcia Campos 2021-06-15 05:25:57 PDT 
Created attachment 431425 [details]
Patch
Comment 2 Michael Catanzaro 2021-06-15 05:38:51 PDT 
Comment on attachment 431425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431425&action=review

> Tools/TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:40
> +        certificate = adoptGRef(g_tls_certificate_new_from_files(sslCertificateFile.get(), sslKeyFile.get(), nullptr));

Bonus points if you pass an error parameter and g_assert_no_error() before the g_assert_nonnull(). That will give us a better error message in the unlikely event that it ever starts to fail in the future.
Comment 3 Carlos Garcia Campos 2021-06-17 01:38:57 PDT 
Committed r278977 (238903@main): <https://commits.webkit.org/238903@main>
Comment 4 Radar WebKit Bug Importer 2021-06-17 01:39:26 PDT 
<rdar://problem/79439185>