Bug 227008 - [SOUP] Add Timing-Allow-Origin checks to NetworkDataTaskSoup
Summary: [SOUP] Add Timing-Allow-Origin checks to NetworkDataTaskSoup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, Soup
Depends on:
Blocks:
 
Reported: 2021-06-14 20:05 PDT by Arcady Goldmints-Orlov
Modified: 2021-06-18 01:05 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.91 KB, patch)
2021-06-15 18:37 PDT, Arcady Goldmints-Orlov 		no flags Details | Formatted Diff | Diff
Patch (10.61 KB, patch)
2021-06-17 02:18 PDT, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arcady Goldmints-Orlov 2021-06-14 20:05:04 PDT 
Bug 226678 moved Timing-Allow-Origin checks to the network process on cocoa but did not do so for soup. It also added a number of web platform tests for Timing-Allow-Origin that fail on Linux. NetworkDataTaskSoup::continueHTTPRedirection() needs to add the checks as mentioned in the FIXME comment in that method.
Comment 1 Arcady Goldmints-Orlov 2021-06-15 18:37:06 PDT 
Created attachment 431508 [details]
Patch
Comment 2 EWS 2021-06-16 01:11:25 PDT 
Committed r278924 (238855@main): <https://commits.webkit.org/238855@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431508 [details].
Comment 3 Radar WebKit Bug Importer 2021-06-16 01:12:18 PDT 
<rdar://problem/79384792>
Comment 4 Arcady Goldmints-Orlov 2021-06-16 08:55:37 PDT 
Reopening to track the fix.
Comment 5 Carlos Garcia Campos 2021-06-17 02:18:29 PDT 
Created attachment 431639 [details]
Patch
Comment 6 Carlos Garcia Campos 2021-06-18 01:05:35 PDT 
Committed r279032 (238952@main): <https://commits.webkit.org/238952@main>