Bug 226997 – Font::applyTransforms() can redirect GlyphBuffer's internal pointers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Font::applyTransforms() can redirect GlyphBuffer's internal pointers

[Myles C. Maxfield]

Created attachment 431381 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/78704666>

[Sam Weinig]

Comment on attachment 431381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431381&action=review

> Source/WebCore/ChangeLog:11
> +        Untested.

I applaud the candor, but why is that?

[Myles C. Maxfield]

Created attachment 431390 [details]
Patch

[Ryosuke Niwa]

(In reply to Sam Weinig from comment #3)
> Comment on attachment 431381 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431381&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        Untested.
> 
> I applaud the candor, but why is that?

Please see the radar.

[Sam Weinig]

(In reply to Ryosuke Niwa from comment #5)
> (In reply to Sam Weinig from comment #3)
> > Comment on attachment 431381 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=431381&action=review
> > 
> > > Source/WebCore/ChangeLog:11
> > > +        Untested.
> > 
> > I applaud the candor, but why is that?
> 
> Please see the radar.

Let's be a bit less cavalier with our word choices in the future then.

[EWS]

Committed r278858 (238802@main): <https://commits.webkit.org/238802@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431390 [details].