Bug 226997 - Font::applyTransforms() can redirect GlyphBuffer's internal pointers
Summary: Font::applyTransforms() can redirect GlyphBuffer's internal pointers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-14 16:24 PDT by Myles C. Maxfield
Modified: 2021-06-14 20:34 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.69 KB, patch)
2021-06-14 16:26 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (1.67 KB, patch)
2021-06-14 17:41 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-06-14 16:24:56 PDT
Font::applyTransforms() can redirect GlyphBuffer's internal pointers
Comment 1 Myles C. Maxfield 2021-06-14 16:26:48 PDT
Created attachment 431381 [details]
Patch
Comment 2 Myles C. Maxfield 2021-06-14 16:26:51 PDT
<rdar://problem/78704666>
Comment 3 Sam Weinig 2021-06-14 17:25:17 PDT
Comment on attachment 431381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431381&action=review

> Source/WebCore/ChangeLog:11
> +        Untested.

I applaud the candor, but why is that?
Comment 4 Myles C. Maxfield 2021-06-14 17:41:43 PDT
Created attachment 431390 [details]
Patch
Comment 5 Ryosuke Niwa 2021-06-14 17:58:58 PDT
(In reply to Sam Weinig from comment #3)
> Comment on attachment 431381 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431381&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        Untested.
> 
> I applaud the candor, but why is that?

Please see the radar.
Comment 6 Sam Weinig 2021-06-14 19:55:14 PDT
(In reply to Ryosuke Niwa from comment #5)
> (In reply to Sam Weinig from comment #3)
> > Comment on attachment 431381 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=431381&action=review
> > 
> > > Source/WebCore/ChangeLog:11
> > > +        Untested.
> > 
> > I applaud the candor, but why is that?
> 
> Please see the radar.

Let's be a bit less cavalier with our word choices in the future then.
Comment 7 EWS 2021-06-14 20:34:47 PDT
Committed r278858 (238802@main): <https://commits.webkit.org/238802@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431390 [details].