Bug 226996 – [JSC] Workaround ICU uloc_addLikelySubtags / uloc_minimizeSubtags bugs

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Workaround ICU uloc_addLikelySubtags / uloc_minimizeSubtags bugs

[Yusuke Suzuki]

Created attachment 431384 [details]
Patch

[Yusuke Suzuki]

<rdar://problem/79250513>

[Ross Kirsling]

Comment on attachment 431384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431384&action=review

All of our ICU workaround code honestly makes me want to cry, but r=me. 😅

> Source/JavaScriptCore/ChangeLog:18
> +        This is workaround, and still this workaround is not complete since we could have many variants. In that case, uloc_addLikelySubtags / uloc_minimizeSubtags
> +        still fails, and in that case, for now, we give up performing uloc_addLikelySubtags / uloc_minimizeSubtags. Fixing this needs to be
> +        done in ICU side.

We should create a JIRA ticket for this.

> JSTests/stress/intl-long-locale-id-maximize-minimize.js:6
> +    const __v_16 = new Intl.Locale(`de-Latn-DE-u-cu-eur-em-default-hc-h23-ks-level1-lb-strict-lw-normal-ms-metric-nu-latn-rg-atzzzz-sd-atat1-ss-none-tz-atvie-va-posix`);

Let's use less cryptic variable names.

[Yusuke Suzuki]

Comment on attachment 431384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431384&action=review

Thanks!

>> Source/JavaScriptCore/ChangeLog:18
>> +        done in ICU side.
> 
> We should create a JIRA ticket for this.

Filed https://unicode-org.atlassian.net/browse/ICU-21639

>> JSTests/stress/intl-long-locale-id-maximize-minimize.js:6
>> +    const __v_16 = new Intl.Locale(`de-Latn-DE-u-cu-eur-em-default-hc-h23-ks-level1-lb-strict-lw-normal-ms-metric-nu-latn-rg-atzzzz-sd-atat1-ss-none-tz-atvie-va-posix`);
> 
> Let's use less cryptic variable names.

Changed.

[Yusuke Suzuki]

Committed r278859 (238803@main): <https://commits.webkit.org/238803@main>