Bug 226990 - Remove Storage Access API quirk on live.com
Summary: Remove Storage Access API quirk on live.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-14 14:28 PDT by Kate Cheney
Modified: 2021-06-14 16:41 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.02 KB, patch)
2021-06-14 14:29 PDT, Kate Cheney 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.08 KB, patch)
2021-06-14 15:03 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2021-06-14 14:28:44 PDT 
Remove Storage Access API quirk on live.com
Comment 1 Kate Cheney 2021-06-14 14:29:56 PDT 
Created attachment 431365 [details]
Patch
Comment 2 Brent Fulgham 2021-06-14 14:41:50 PDT 
Comment on attachment 431365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431365&action=review

r=me

> Source/WebCore/page/Quirks.cpp:1055
>          && (element.classNames().contains("glyph_signIn_circle")

Observation: It sure seems like there should be a predicate that lets us test if one set contains any of another set...
Comment 3 Kate Cheney 2021-06-14 15:03:53 PDT 
Created attachment 431369 [details]
Patch
Comment 4 Kate Cheney 2021-06-14 15:05:14 PDT 
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 431365 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431365&action=review
> 
> r=me
> 
> > Source/WebCore/page/Quirks.cpp:1055
> >          && (element.classNames().contains("glyph_signIn_circle")
> 
> Observation: It sure seems like there should be a predicate that lets us
> test if one set contains any of another set...

Agreed, this would be useful for quirks when we check for similar classnames. 

Awaiting EWS before landing. Thanks for the review!
Comment 5 EWS 2021-06-14 16:40:16 PDT 
Committed r278852 (238798@main): <https://commits.webkit.org/238798@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431369 [details].
Comment 6 Kate Cheney 2021-06-14 16:41:09 PDT 
rdar://79218986