RESOLVED FIXED 226988
[watchOS] Reenable modern text input UI for non-numeric text input types 
https://bugs.webkit.org/show_bug.cgi?id=226988
Summary [watchOS] Reenable modern text input UI for non-numeric text input types
Wenson Hsieh
Reported 2021-06-14 14:06:31 PDT
rdar://78102953
Attachments
For EWS (52.86 KB, patch)
2021-06-14 15:43 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
For EWS (53.51 KB, patch)
2021-06-14 15:59 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
For EWS (55.29 KB, patch)
2021-06-14 16:06 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
For EWS (55.32 KB, patch)
2021-06-14 16:14 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Remove unnecesary comment (55.93 KB, patch)
2021-06-15 12:01 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Small adjustment (55.90 KB, patch)
2021-06-15 13:34 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Rebase after r278910 (57.11 KB, patch)
2021-06-15 16:27 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Rebase on trunk (55.54 KB, patch)
2021-06-16 13:56 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix more conflicts (54.83 KB, patch)
2021-06-16 14:17 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-06-14 15:43:28 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2021-06-14 15:59:10 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 3 2021-06-14 16:06:22 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 4 2021-06-14 16:14:24 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 5 2021-06-15 12:01:20 PDT
Created attachment 431461 [details] Remove unnecesary comment
Aditya Keerthi
Comment 6 2021-06-15 13:10:30 PDT
Comment on attachment 431461 [details] Remove unnecesary comment View in context: https://bugs.webkit.org/attachment.cgi?id=431461&action=review > Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:141 > + [_contextView setFrame:CGRectMake((viewWidth - sizeThatFits.width) / 2, 0, sizeThatFits.width, sizeThatFits.height)]; > + [_contextView layoutSubviews]; I don't think `layoutSubviews` is necessary – the frame change (specifically the change to size) should trigger layout.
Wenson Hsieh
Comment 7 2021-06-15 13:32:40 PDT
(In reply to Aditya Keerthi from comment #6) > Comment on attachment 431461 [details] > Remove unnecesary comment > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431461&action=review > > > Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:141 > > + [_contextView setFrame:CGRectMake((viewWidth - sizeThatFits.width) / 2, 0, sizeThatFits.width, sizeThatFits.height)]; > > + [_contextView layoutSubviews]; > > I don't think `layoutSubviews` is necessary – the frame change (specifically > the change to size) should trigger layout. Good catch! Removed this call to -layoutSubviews.
Wenson Hsieh
Comment 8 2021-06-15 13:34:53 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 9 2021-06-15 16:27:02 PDT Comment hidden (obsolete)
EWS
Comment 10 2021-06-16 13:27:22 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 11 2021-06-16 13:56:29 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 12 2021-06-16 14:17:46 PDT
Created attachment 431602 [details] Fix more conflicts
EWS
Comment 13 2021-06-16 15:18:45 PDT
Committed r278957 (238885@main): <https://commits.webkit.org/238885@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431602 [details].
Note You need to log in before you can comment on or make changes to this bug.