rdar://78102953
Created attachment 431374 [details] For EWS
Created attachment 431375 [details] For EWS
Created attachment 431377 [details] For EWS
Created attachment 431378 [details] For EWS
Created attachment 431461 [details] Remove unnecesary comment
Comment on attachment 431461 [details] Remove unnecesary comment View in context: https://bugs.webkit.org/attachment.cgi?id=431461&action=review > Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:141 > + [_contextView setFrame:CGRectMake((viewWidth - sizeThatFits.width) / 2, 0, sizeThatFits.width, sizeThatFits.height)]; > + [_contextView layoutSubviews]; I don't think `layoutSubviews` is necessary – the frame change (specifically the change to size) should trigger layout.
(In reply to Aditya Keerthi from comment #6) > Comment on attachment 431461 [details] > Remove unnecesary comment > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431461&action=review > > > Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:141 > > + [_contextView setFrame:CGRectMake((viewWidth - sizeThatFits.width) / 2, 0, sizeThatFits.width, sizeThatFits.height)]; > > + [_contextView layoutSubviews]; > > I don't think `layoutSubviews` is necessary – the frame change (specifically > the change to size) should trigger layout. Good catch! Removed this call to -layoutSubviews.
Created attachment 431476 [details] Small adjustment
Created attachment 431493 [details] Rebase after r278910
Tools/Scripts/svn-apply failed to apply attachment 431493 [details] to trunk. Please resolve the conflicts and upload a new patch.
Created attachment 431598 [details] Rebase on trunk
Created attachment 431602 [details] Fix more conflicts
Committed r278957 (238885@main): <https://commits.webkit.org/238885@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431602 [details].