Bug 226978 – [Mac] CoreMedia WrapperClass does not need alignment fixup

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

CoreMedia WrapperClass does not need the alignment fixup required by CMBaseClass

[Eric Carlson]

rdar://78864290

[Eric Carlson]

Created attachment 431348 [details]
Patch

[Geoffrey Garen]

Comment on attachment 431348 [details]
Patch

r=me

Comment on attachment 431348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431348&action=review

> Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:158
> +    static constexpr struct { WrapperClass derivedClass; } derivedClass { Wrapped::wrapperClass() };

Don’t really need this to be a struct anymore.

Comment on attachment 431348 [details]
Patch

Didn’t mean to reset Geoff’s r+ though.

[Geoffrey Garen]

> > Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:158
> > +    static constexpr struct { WrapperClass derivedClass; } derivedClass { Wrapped::wrapperClass() };
> 
> Don’t really need this to be a struct anymore.

👍🏻

[Eric Carlson]

(In reply to mitz from comment #4)
> Comment on attachment 431348 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431348&action=review
> 
> > Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:158
> > +    static constexpr struct { WrapperClass derivedClass; } derivedClass { Wrapped::wrapperClass() };
> 
> Don’t really need this to be a struct anymore.

Good point, thanks!

[Eric Carlson]

Created attachment 431357 [details]
Patch

[EWS]

Found 1 new test failure: imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel-service-worker.https.html

[Eric Carlson]

Comment on attachment 431357 [details]
Patch

Failing test is unrelated

[EWS]

Committed r278870 (238814@main): <https://commits.webkit.org/238814@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431357 [details].