Bug 226978 - [Mac] CoreMedia WrapperClass does not need alignment fixup
Summary: [Mac] CoreMedia WrapperClass does not need alignment fixup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-14 09:30 PDT by Eric Carlson
Modified: 2021-06-15 06:14 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.79 KB, patch)
2021-06-14 11:51 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (5.95 KB, patch)
2021-06-14 13:01 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2021-06-14 09:30:50 PDT 
CoreMedia WrapperClass does not need the alignment fixup required by CMBaseClass
Comment 1 Eric Carlson 2021-06-14 09:31:08 PDT 
rdar://78864290
Comment 2 Eric Carlson 2021-06-14 11:51:12 PDT 
Created attachment 431348 [details]
Patch
Comment 3 Geoffrey Garen 2021-06-14 11:57:34 PDT 
Comment on attachment 431348 [details]
Patch

r=me
Comment 4 mitz 2021-06-14 11:57:48 PDT 
Comment on attachment 431348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431348&action=review

> Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:158
> +    static constexpr struct { WrapperClass derivedClass; } derivedClass { Wrapped::wrapperClass() };

Don’t really need this to be a struct anymore.
Comment 5 mitz 2021-06-14 11:58:30 PDT 
Comment on attachment 431348 [details]
Patch

Didn’t mean to reset Geoff’s r+ though.
Comment 6 Geoffrey Garen 2021-06-14 11:59:35 PDT 
> > Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:158
> > +    static constexpr struct { WrapperClass derivedClass; } derivedClass { Wrapped::wrapperClass() };
> 
> Don’t really need this to be a struct anymore.

👍🏻
Comment 7 Eric Carlson 2021-06-14 12:46:58 PDT 
(In reply to mitz from comment #4)
> Comment on attachment 431348 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431348&action=review
> 
> > Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.h:158
> > +    static constexpr struct { WrapperClass derivedClass; } derivedClass { Wrapped::wrapperClass() };
> 
> Don’t really need this to be a struct anymore.

Good point, thanks!
Comment 8 Eric Carlson 2021-06-14 13:01:05 PDT 
Created attachment 431357 [details]
Patch
Comment 9 EWS 2021-06-14 14:47:08 PDT 
Found 1 new test failure: imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel-service-worker.https.html
Comment 10 Eric Carlson 2021-06-15 06:10:39 PDT 
Comment on attachment 431357 [details]
Patch

Failing test is unrelated
Comment 11 EWS 2021-06-15 06:14:03 PDT 
Committed r278870 (238814@main): <https://commits.webkit.org/238814@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431357 [details].