Bug 22697 - Move JIT::compileOpStrictEq to MacroAssembler interface.
Summary: Move JIT::compileOpStrictEq to MacroAssembler interface.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-05 15:45 PST by Gavin Barraclough
Modified: 2008-12-05 15:57 PST (History)
0 users

See Also:


Attachments
The patch (8.07 KB, patch)
2008-12-05 15:47 PST, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-12-05 15:45:47 PST
Committing this as an individual patch, since the code is also substantially rejigged.
Comment 1 Gavin Barraclough 2008-12-05 15:47:28 PST
Created attachment 25796 [details]
The patch
Comment 2 Geoffrey Garen 2008-12-05 15:52:20 PST
Comment on attachment 25796 [details]
The patch

> 7         The rewrite also looks like a small (<1%) performance progression.

Should mention what test you ran.

> +    // Check that bot are immediates, if so check if they're equal

Typo: "both."

r=me
Comment 3 Gavin Barraclough 2008-12-05 15:57:42 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/jit/JIT.cpp
Sending        JavaScriptCore/jit/JIT.h
Sending        JavaScriptCore/jit/JITInlineMethods.h
Transmitting file data ....
Committed revision 39053.