Bug 226962 - FilterEffectRendererCoreImage could be simpler and more memory efficient
Summary: FilterEffectRendererCoreImage could be simpler and more memory efficient
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 226917
Blocks:
  Show dependency tree / graph
 
Reported: 2021-06-14 02:15 PDT by Kimmo Kinnunen
Modified: 2022-05-31 12:23 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.33 KB, patch)
2021-06-14 03:14 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (17.34 KB, patch)
2021-06-17 23:55 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-06-14 02:15:40 PDT 
FilterEffectRendererCoreImage could be simpler and more memory efficient
- functions applyEffects and renderToImageBuffer are simple functions that cannot function realistically without each other but work and mutate the object state
- holds the bitmaps while allocating new bitmaps
Comment 1 Kimmo Kinnunen 2021-06-14 03:14:23 PDT 
Created attachment 431308 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-06-17 23:55:44 PDT 
Created attachment 431759 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2021-06-21 02:16:40 PDT 
<rdar://problem/79553333>
Comment 4 Simon Fraser (smfr) 2021-06-21 10:31:15 PDT 
This code is off by default.
Comment 5 Dean Jackson 2022-02-19 08:22:42 PST 
Comment on attachment 431759 [details]
Patch

r=me although I would not be surprised if this patch no longer applies.
Comment 6 Said Abou-Hallawa 2022-05-31 12:22:57 PDT 
FilterEffectRendererCoreImage was removed in r286193.