Bug 22696 - Canvas without pixel tests
Summary: Canvas without pixel tests
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-05 15:26 PST by Dirk Schulze
Modified: 2008-12-09 04:37 PST (History)
0 users

See Also:


Attachments
pixel test replacement (24.77 KB, patch)
2008-12-05 15:27 PST, Dirk Schulze
oliver: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2008-12-05 15:26:53 PST
There are still some pixel tests left in fast/canvas. They should be replaced by js-tests with getImageData.
Comment 1 Dirk Schulze 2008-12-05 15:27:56 PST
Created attachment 25793 [details]
pixel test replacement

This replaces the pixel tests by getImageData tests.
Comment 2 Oliver Hunt 2008-12-07 01:45:50 PST
Comment on attachment 25793 [details]
pixel test replacement

My concern lies primarily with the under sampling -- i think that for identity, multiply, and skewed transform checks the pixel tests actually make sense -- the text based canvas tests are used to test rendering behaviour of specific features simply by drawing simple rects, and sampling multiple points inside and outside those rects (because we're testing positioning behaviour or making sure certain operations are ignored so only a limited number of samples are needed)

For things like transform-skew we really need to make sure that the shape is correct, hence pixel tests are reasonable.