Bug 226955 - Number pad button is missing its image when tapping on <input type=tel> in watchOS 8
Summary: Number pad button is missing its image when tapping on <input type=tel> in wa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-12 11:50 PDT by Wenson Hsieh
Modified: 2021-06-12 15:31 PDT (History)
11 users (show)

See Also:

Attachments
For EWS (3.52 KB, patch)
2021-06-12 11:56 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Fix watchOS 7 build (4.79 KB, patch)
2021-06-12 12:30 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Fix watchOS 7 build (2) (4.79 KB, patch)
2021-06-12 12:43 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-06-12 11:50:24 PDT 
.
Comment 1 Wenson Hsieh 2021-06-12 11:56:25 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-06-12 12:30:45 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2021-06-12 12:43:29 PDT 
Created attachment 431263 [details]
Fix watchOS 7 build (2)
Comment 4 Darin Adler 2021-06-12 14:07:39 PDT 
Comment on attachment 431263 [details]
Fix watchOS 7 build (2)

View in context: https://bugs.webkit.org/attachment.cgi?id=431263&action=review

> Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:-67
> -    UIImage *numberPadButtonIcon = [PUICResources imageNamed:@"QuickboardAddPhoneNumber" inBundle:[NSBundle bundleWithIdentifier:@"com.apple.PepperUICore"] shouldCache:YES];

So this is not needed on older builds with !HAVE(PUIC_BUTTON_TYPE_PILL)?
Comment 5 Wenson Hsieh 2021-06-12 14:11:06 PDT 
Comment on attachment 431263 [details]
Fix watchOS 7 build (2)

View in context: https://bugs.webkit.org/attachment.cgi?id=431263&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:-67
>> -    UIImage *numberPadButtonIcon = [PUICResources imageNamed:@"QuickboardAddPhoneNumber" inBundle:[NSBundle bundleWithIdentifier:@"com.apple.PepperUICore"] shouldCache:YES];
> 
> So this is not needed on older builds with !HAVE(PUIC_BUTTON_TYPE_PILL)?

Yes — setting the Quickboard action type obviates the need for specifying this icon image on both watchOS 7+.
Comment 6 EWS 2021-06-12 14:45:38 PDT 
Committed r278815 (238768@main): <https://commits.webkit.org/238768@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431263 [details].
Comment 7 Radar WebKit Bug Importer 2021-06-12 14:46:20 PDT 
<rdar://problem/79246073>