Bug 226955 – Number pad button is missing its image when tapping on <input type=tel> in watchOS 8

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Wenson Hsieh]

.

[Wenson Hsieh]

Created attachment 431261 [details]
For EWS

[Wenson Hsieh]

Created attachment 431262 [details]
Fix watchOS 7 build

[Wenson Hsieh]

Created attachment 431263 [details]
Fix watchOS 7 build (2)

[Darin Adler]

Comment on attachment 431263 [details]
Fix watchOS 7 build (2)

View in context: https://bugs.webkit.org/attachment.cgi?id=431263&action=review

> Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:-67
> -    UIImage *numberPadButtonIcon = [PUICResources imageNamed:@"QuickboardAddPhoneNumber" inBundle:[NSBundle bundleWithIdentifier:@"com.apple.PepperUICore"] shouldCache:YES];

So this is not needed on older builds with !HAVE(PUIC_BUTTON_TYPE_PILL)?

[Wenson Hsieh]

Comment on attachment 431263 [details]
Fix watchOS 7 build (2)

View in context: https://bugs.webkit.org/attachment.cgi?id=431263&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:-67
>> -    UIImage *numberPadButtonIcon = [PUICResources imageNamed:@"QuickboardAddPhoneNumber" inBundle:[NSBundle bundleWithIdentifier:@"com.apple.PepperUICore"] shouldCache:YES];
> 
> So this is not needed on older builds with !HAVE(PUIC_BUTTON_TYPE_PILL)?

Yes — setting the Quickboard action type obviates the need for specifying this icon image on both watchOS 7+.

[EWS]

Committed r278815 (238768@main): <https://commits.webkit.org/238768@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431263 [details].

[Radar WebKit Bug Importer]

<rdar://problem/79246073>