Bug 226943 - Use SharedBuffer!=() in CachedResource::tryReplaceEncodedData()
Summary: Use SharedBuffer!=() in CachedResource::tryReplaceEncodedData()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2021-06-11 15:27 PDT by Chris Dumez
Modified: 2021-06-11 16:37 PDT (History)
8 users (show)

See Also:

Patch (2.09 KB, patch)
2021-06-11 15:29 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (2.08 KB, patch)
2021-06-11 15:33 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-06-11 15:27:44 PDT
Use SharedBuffer!=() in CachedResource::tryReplaceEncodedData() instead of duplicating its logic. SharedBuffer==() is also potentially more efficient since it doesn't requires combining the SharedBuffers' data segments.
Comment 1 Chris Dumez 2021-06-11 15:29:14 PDT
Created attachment 431235 [details]
Comment 2 Geoffrey Garen 2021-06-11 15:32:06 PDT
Comment on attachment 431235 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=431235&action=review


> Source/WebCore/loader/cache/CachedResource.cpp:917
> +    // We have to do the compare the buffers because we can't tell if the replacement file backed data is for the

to do the compare the buffers => compare the buffers
Comment 3 Chris Dumez 2021-06-11 15:33:30 PDT
Created attachment 431236 [details]
Comment 4 EWS 2021-06-11 16:36:40 PDT
Committed r278793 (238750@main): <https://commits.webkit.org/238750@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431236 [details].
Comment 5 Radar WebKit Bug Importer 2021-06-11 16:37:19 PDT