WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
22693
Remove m_assembler from MacroAssembler::Jump.
https://bugs.webkit.org/show_bug.cgi?id=22693
Summary
Remove m_assembler from MacroAssembler::Jump.
Gavin Barraclough
Reported
2008-12-05 13:57:31 PST
Keeping a pointer allowed for some syntactic sugar - "link()" looks nicer than "link(this)". But maintaining this doubles the size of Jump, which is even more unfortunate for the JIT, since there are many large structures holding JmpSrcs. Probably best to remove it.
Attachments
The patch
(20.89 KB, patch)
2008-12-05 13:59 PST
,
Gavin Barraclough
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2008-12-05 13:59:31 PST
Created
attachment 25787
[details]
The patch
Geoffrey Garen
Comment 2
2008-12-05 14:10:11 PST
Comment on
attachment 25787
[details]
The patch r=me
Gavin Barraclough
Comment 3
2008-12-05 14:14:13 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/MacroAssembler.h Sending JavaScriptCore/wrec/WREC.cpp Sending JavaScriptCore/wrec/WRECGenerator.cpp Sending JavaScriptCore/wrec/WRECParser.h Transmitting file data ..... Committed revision 39043.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug