Bug 22693 - Remove m_assembler from MacroAssembler::Jump.
Summary: Remove m_assembler from MacroAssembler::Jump.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
Depends on:
Reported: 2008-12-05 13:57 PST by Gavin Barraclough
Modified: 2008-12-05 14:14 PST (History)
0 users

See Also:

The patch (20.89 KB, patch)
2008-12-05 13:59 PST, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-12-05 13:57:31 PST
Keeping a pointer allowed for some syntactic sugar - "link()" looks nicer than "link(this)".  But maintaining this doubles the size of Jump, which is even more unfortunate for the JIT, since there are many large structures holding JmpSrcs.  Probably best to remove it.
Comment 1 Gavin Barraclough 2008-12-05 13:59:31 PST
Created attachment 25787 [details]
The patch
Comment 2 Geoffrey Garen 2008-12-05 14:10:11 PST
Comment on attachment 25787 [details]
The patch

Comment 3 Gavin Barraclough 2008-12-05 14:14:13 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/assembler/MacroAssembler.h
Sending        JavaScriptCore/wrec/WREC.cpp
Sending        JavaScriptCore/wrec/WRECGenerator.cpp
Sending        JavaScriptCore/wrec/WRECParser.h
Transmitting file data .....
Committed revision 39043.