Bug 226925 - [check-webkit-style] failing in JS checker due to python byte string
Summary: [check-webkit-style] failing in JS checker due to python byte string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
: 226904 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-06-11 09:12 PDT by Jonathan Bedard
Modified: 2021-06-11 20:08 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.12 KB, patch)
2021-06-11 09:16 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (3.86 KB, patch)
2021-06-11 09:20 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-06-11 09:12:07 PDT 
We read JS files in as binary, but then run string regexes against the binary content, which doesn't work.
Comment 1 Jonathan Bedard 2021-06-11 09:12:30 PDT 
<rdar://problem/79166108>
Comment 2 Jonathan Bedard 2021-06-11 09:16:09 PDT 
Created attachment 431204 [details]
Patch
Comment 3 Jonathan Bedard 2021-06-11 09:20:55 PDT 
Created attachment 431205 [details]
Patch
Comment 4 Russell Epstein 2021-06-11 10:18:41 PDT 
r=me
Comment 5 Jonathan Bedard 2021-06-11 10:34:45 PDT 
Russell isn't a reviewer, so that "r+" is really an "unofficial r+"
Comment 6 EWS 2021-06-11 11:37:34 PDT 
Committed r278771 (238730@main): <https://commits.webkit.org/238730@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431205 [details].
Comment 7 Ryan Haddad 2021-06-11 20:08:34 PDT 
*** Bug 226904 has been marked as a duplicate of this bug. ***