Bug 226920 - GLES and EGL from ANGLE should link with libdl
Summary: GLES and EGL from ANGLE should link with libdl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Local Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-11 07:54 PDT by Eleni Maria Stea
Modified: 2021-06-11 11:09 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2021-06-11 08:00 PDT, Eleni Maria Stea 		no flags Details | Formatted Diff | Diff
Patch (1.99 KB, patch)
2021-06-11 08:27 PDT, Eleni Maria Stea 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eleni Maria Stea 2021-06-11 07:54:05 PDT 
GLES and EGL that are generated from ANGLE should link with libdl because they use dlsym and dlopen.

Also, initially I thought that we shouldn't link with libEGL when we use USE_ANGLE_WEBGL instead of USE_ANGLE_EGL because the symbols of EGL were found in generated libGLES. But with the new CMakeLists.txt I see that libEGL contains the right symbols and so, we can link with it in both cases.
Comment 1 Eleni Maria Stea 2021-06-11 08:00:56 PDT 
Created attachment 431194 [details]
Patch
Comment 2 EWS Watchlist 2021-06-11 08:02:03 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Eleni Maria Stea 2021-06-11 08:27:37 PDT 
Created attachment 431197 [details]
Patch
Comment 4 Eleni Maria Stea 2021-06-11 08:29:50 PDT 
[Update]: I've removed EGL from the case we use WEBGL and fixed -dl to be platform specific using the CMake variable (thanks Don Olmstead!).
Comment 5 Kenneth Russell 2021-06-11 10:33:51 PDT 
Comment on attachment 431197 [details]
Patch

Looks good; r+.
Comment 6 EWS 2021-06-11 11:08:40 PDT 
Committed r278768 (238727@main): <https://commits.webkit.org/238727@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431197 [details].
Comment 7 Radar WebKit Bug Importer 2021-06-11 11:09:23 PDT 
<rdar://problem/79207140>