Bug 226909 – Use DOMConstructor array instead of HashMap since window constructor property access is critical

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

Use DOMConstructor array instead of HashMap since window constructor property access is critical

[Yusuke Suzuki]

Created attachment 431168 [details]
Patch

[Yusuke Suzuki]

Created attachment 431170 [details]
Patch

[Chris Dumez]

Comment on attachment 431170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431170&action=review

> Source/WebCore/ChangeLog:12
> +        preprocess-idls.pl collects all constructors and assign DOMConstructor::XXX enum to each constructor. And it also counts

What about constructors added at runtime (e.g. the ones marked as [EnabledAtRuntime] or [EnabledBySetting]) ?

[Yusuke Suzuki]

Comment on attachment 431170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431170&action=review

>> Source/WebCore/ChangeLog:12
>> +        preprocess-idls.pl collects all constructors and assign DOMConstructor::XXX enum to each constructor. And it also counts
> 
> What about constructors added at runtime (e.g. the ones marked as [EnabledAtRuntime] or [EnabledBySetting]) ?

Regardless of whether it is defined at runtime, we have ID for that constructor.

[Yusuke Suzuki]

Created attachment 431171 [details]
Patch

[Yusuke Suzuki]

Committed r278802 (238759@main): <https://commits.webkit.org/238759@main>

[Radar WebKit Bug Importer]

<rdar://problem/79226523>

[Darin Adler]

Comment on attachment 431171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431171&action=review

> Source/WebCore/bindings/js/JSDOMGlobalObject.h:127
> +    std::unique_ptr<DOMConstructors> m_constructors;

Can this be std::unique_ptr<const DOMConstructors>? If not, why not?

[Sam Weinig]

Nice. Should we do this for the DOM Structures map too?

[Yusuke Suzuki]

Comment on attachment 431171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431171&action=review

>> Source/WebCore/bindings/js/JSDOMGlobalObject.h:127
>> +    std::unique_ptr<DOMConstructors> m_constructors;
> 
> Can this be std::unique_ptr<const DOMConstructors>? If not, why not?

Because DOMConstructors will be modified :)

[Yusuke Suzuki]

(In reply to Sam Weinig from comment #9)
> Nice. Should we do this for the DOM Structures map too?

Possibly yes :)
Or, we could extend it to using LazyClassStructure (which can hold construtors and structures)