Bug 226905 - [CMake][GTK][WPE] Improve error message when libsoup3 is not found
Summary: [CMake][GTK][WPE] Improve error message when libsoup3 is not found
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
Depends on:
Reported: 2021-06-10 16:25 PDT by Carlos Alberto Lopez Perez
Modified: 2021-06-10 21:52 PDT (History)
11 users (show)

See Also:

Patch (2.87 KB, patch)
2021-06-10 16:28 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2021-06-10 16:25:47 PDT
The packaging bots have been failing to build for a while because SOUP3 is enabled by default and this bots don't have libsoup3 installed on the local jhbuild or the local distro

CMake Error at /usr/share/cmake-3.16/Modules/FindPkgConfig.cmake:463 (message):
  A required package was not found
Call Stack (most recent call first):
  /usr/share/cmake-3.16/Modules/FindPkgConfig.cmake:643 (_pkg_check_modules_internal)
  Source/cmake/FindLibSoup.cmake:45 (pkg_check_modules)
  Source/cmake/WebKitFindPackage.cmake:105 (_find_package)
  Source/cmake/OptionsGTK.cmake:216 (find_package)
  Source/cmake/WebKitCommon.cmake:216 (include)
  CMakeLists.txt:20 (include)


I think it will be an improvement to be more clear with this error.
Comment 1 Carlos Alberto Lopez Perez 2021-06-10 16:28:39 PDT
Created attachment 431159 [details]
Comment 2 EWS 2021-06-10 21:52:31 PDT
Committed r278753 (238714@main): <https://commits.webkit.org/238714@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431159 [details].