Bug 226902 - allow callers of `shouldBecome*` to specify a maximum time to wait in LayoutTests
Summary: allow callers of `shouldBecome*` to specify a maximum time to wait in LayoutT...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-10 15:58 PDT by Devin Rousso
Modified: 2021-06-17 16:00 PDT (History)
8 users (show)

See Also:

Attachments
Patch (20.65 KB, patch)
2021-06-10 16:05 PDT, Devin Rousso 		hi: review?
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-06-10 15:58:46 PDT 
also add a way to guard general `await promise` with a timeout
Comment 1 Devin Rousso 2021-06-10 16:05:51 PDT 
Created attachment 431154 [details]
Patch
Comment 2 Devin Rousso 2021-06-11 12:26:21 PDT 
Comment on attachment 431154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431154&action=review

> LayoutTests/ChangeLog:51
> +2021-06-10  Devin Rousso  <drousso@apple.com>

oh oops i will remove before landing

i want to give EWS a chance to fully run on this patch before uploading a new one since this patch modifies some very commonly used stuff
Comment 3 Radar WebKit Bug Importer 2021-06-17 16:00:04 PDT 
<rdar://problem/79475176>