Bug 226884 – REGRESSION: service-workers/service-worker/credentials.https.html and content-security-policy/reporting/report-only-in-meta.sub.html failing together constantly.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Truitt Savell]

imported/w3c/web-platform-tests/service-workers/service-worker/credentials.https.html
imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub.html

these two tests began failing at the same time according to history. I am able to reproduce them with command:
run-webkit-tests imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub.html imported/w3c/web-platform-tests/service-workers/service-worker/credentials.https.html --iterations 50 -f


but they fail on every revision I test them on, so I can't find a solid bisection point

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Fcredentials.https.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcontent-security-policy%2Freporting%2Freport-only-in-meta.sub.html

Diffs:
--- /Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/credentials.https-expected.txt
+++ /Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/credentials.https-actual.txt
@@ -1,5 +1,5 @@
 
 PASS Set cookies as initialization
-PASS Main script should have credentials
-FAIL Imported script should have credentials promise_test: Unhandled rejection with value: object "TypeError: null is not an object (evaluating 'worker.postMessage')"
+FAIL Main script should have credentials assert_equals: new worker has credentials expected (string) "1" but got (undefined) undefined
+FAIL Imported script should have credentials assert_equals: new worker has credentials expected (string) "1" but got (undefined) undefined
 

--- /Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub-expected.txt
+++ /Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub-actual.txt
@@ -1,6 +1,7 @@
 
+
+Harness Error (FAIL), message = TypeError: undefined is not an object (evaluating 'cookies[i].split('=')[1].trim')
 
 PASS Image should load
 PASS checkReport tests loaded
-PASS Violation report status OK.

[Radar WebKit Bug Importer]

<rdar://problem/79148983>

[Truitt Savell]

marked these tests as failing while investigating to help EWS https://trac.webkit.org/changeset/278713/webkit

[Chris Dumez]

The issue is with LayoutTests/imported/w3c/web-platform-tests/cookies/resources/set-cookie.py:

        ("Set-Cookie", "{name[0]}=1; Path={path[0]}; Expires=Wed, 09 Jun 2021 10:18:14 GMT".format(**params))


The cookie has an explicit expiration date that has just passed.

[Chris Dumez]

Created attachment 431111 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Geoffrey Garen]

Comment on attachment 431111 [details]
Patch

r=me

[EWS]

Found 1 new test failure: imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub.html

[Chris Dumez]

Created attachment 431156 [details]
Patch

[Chris Dumez]

Committed r278742 (238704@main): <https://commits.webkit.org/238704@main>