Bug 226882 - [MSE] Prevent false-positive "stalled" event iff MSE used
Summary: [MSE] Prevent false-positive "stalled" event iff MSE used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-10 09:22 PDT by Enrique Ocaña
Modified: 2021-09-06 18:39 PDT (History)
19 users (show)

See Also:

Attachments
Patch (5.29 KB, patch)
2021-06-10 09:36 PDT, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Patch (7.08 KB, patch)
2021-09-06 08:51 PDT, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña 2021-06-10 09:22:09 PDT 
"progress" and "stalled" events make no sense in context of MSE: https://github.com/w3c/media-source/issues/88
and hence they will likely be removed soon: https://w3c.github.io/media-source/#h-note-19
Comment 1 Enrique Ocaña 2021-06-10 09:36:05 PDT 
Created attachment 431089 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-06-17 09:23:38 PDT 
<rdar://problem/79454993>
Comment 3 Alicia Boya García 2021-09-06 03:18:19 PDT 
Comment on attachment 431089 [details]
Patch

LGTM, r+ conditional on tests not regressing.
Comment 4 Enrique Ocaña 2021-09-06 08:51:47 PDT 
Created attachment 437419 [details]
Patch
Comment 5 Enrique Ocaña 2021-09-06 08:54:24 PDT 
Uploaded a new version of the patch. It doesn't require additional review because only a gardening-like change in the expectations of imported/w3c/web-platform-tests/media-source/mediasource-append-buffer-expected.html has been added, in order to avoid regressions in the tests.
Comment 6 EWS 2021-09-06 09:38:35 PDT 
Committed r282059 (241359@main): <https://commits.webkit.org/241359@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437419 [details].
Comment 7 Carlos Alberto Lopez Perez 2021-09-06 18:39:00 PDT 
(In reply to EWS from comment #6)
> Committed r282059 (241359@main): <https://commits.webkit.org/241359@main>
> 
> All reviewed patches have been landed. Closing bug and clearing flags on
> attachment 437419 [details].

This made the test media/media-source/media-source-stalled-holds-sleep-assertion.html to timeout. Check bug 229979