Bug 226880 - Another speculative build fix for Win32.
Summary: Another speculative build fix for Win32.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-10 09:00 PDT by Mark Lam
Modified: 2021-06-10 10:19 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch. (1.67 KB, patch)
2021-06-10 09:11 PDT, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-06-10 09:00:40 PDT 
We're getting reports of "warning C4206: nonstandard extension used: translation unit is empty" turning into a build error on Win32 ports.  By design, we rely on #define flags to make some translation units empty.  Hence, we don't want this warning to turn into an error.

rdar://79124858
Comment 1 Mark Lam 2021-06-10 09:11:23 PDT 
Created attachment 431088 [details]
proposed patch.
Comment 2 Mark Lam 2021-06-10 10:19:25 PDT 
Thanks for the review.  Landed in r278711: <http://trac.webkit.org/r278711>.