WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
226880
Another speculative build fix for Win32.
https://bugs.webkit.org/show_bug.cgi?id=226880
Summary
Another speculative build fix for Win32.
Mark Lam
Reported
2021-06-10 09:00:40 PDT
We're getting reports of "warning C4206: nonstandard extension used: translation unit is empty" turning into a build error on Win32 ports. By design, we rely on #define flags to make some translation units empty. Hence, we don't want this warning to turn into an error.
rdar://79124858
Attachments
proposed patch.
(1.67 KB, patch)
2021-06-10 09:11 PDT
,
Mark Lam
keith_miller
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2021-06-10 09:11:23 PDT
Created
attachment 431088
[details]
proposed patch.
Mark Lam
Comment 2
2021-06-10 10:19:25 PDT
Thanks for the review. Landed in
r278711
: <
http://trac.webkit.org/r278711
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug