These tests are failing with the following output: https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r278650%20%282224%29/media/track/audio/audio-track-mkv-vorbis-language-diff.txt --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/track/audio/audio-track-mkv-vorbis-language-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/track/audio/audio-track-mkv-vorbis-language-actual.txt @@ -5,8 +5,8 @@ ** Check in-band kind attributes EXPECTED (video.audioTracks.length == '2') OK -EXPECTED (video.audioTracks[0].language == 'la') OK -EXPECTED (video.audioTracks[1].language == 'en') OK +EXPECTED (video.audioTracks[0].language == 'la'), OBSERVED 'en' FAIL +EXPECTED (video.audioTracks[1].language == 'en'), OBSERVED 'la' FAIL END OF TEST https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r278651%20%282225%29/media/track/video/video-track-mkv-theora-language-diff.txt --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/track/video/video-track-mkv-theora-language-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/track/video/video-track-mkv-theora-language-actual.txt @@ -5,8 +5,8 @@ ** Check in-band kind attributes EXPECTED (video.videoTracks.length == '2') OK -EXPECTED (video.videoTracks[0].language == 'ru') OK -EXPECTED (video.videoTracks[1].language == 'zh') OK +EXPECTED (video.videoTracks[0].language == 'ru'), OBSERVED 'zh' FAIL +EXPECTED (video.videoTracks[1].language == 'zh'), OBSERVED 'ru' FAIL END OF TEST
Created attachment 431044 [details] Patch
Comment on attachment 431044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431044&action=review > LayoutTests/ChangeLog:23 > + * platform/gtk/media/track/audio/audio-track-mkv-vorbis-language-expected.txt: Added. > + * platform/gtk/media/track/video/video-track-mkv-theora-language-expected.txt: Added. It looks like you have fixed the tests globally, why not replace all existing expectations instead of adding new GTK-specific results?
(In reply to Eric Carlson from comment #2) > Comment on attachment 431044 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431044&action=review > > > LayoutTests/ChangeLog:23 > > + * platform/gtk/media/track/audio/audio-track-mkv-vorbis-language-expected.txt: Added. > > + * platform/gtk/media/track/video/video-track-mkv-theora-language-expected.txt: Added. > > It looks like you have fixed the tests globally, why not replace all > existing expectations instead of adding new GTK-specific results? Agree. I will push a new patch.
Created attachment 431152 [details] Patch
Comment on attachment 431152 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431152&action=review > LayoutTests/media/in-band-tracks.js:58 > + testExpected("video." + type +"Tracks.length", values.length); > + for (var i = 0; i < values.length; ++i) > + testExpected("video." + type +"Tracks[" + i + "]." + attribute, values[i]); > + } else { > + testExpected("video." + type +"Tracks.length", Object.keys(values).length); > + for (let id in values) { > + testExpected(`video.${type}Tracks.getTrackById('${id}').${attribute}`, values[id]); Nit: it is a bit odd to use both template literals and string concatenation in this function.
Created attachment 431382 [details] Patch
Committed r278860 (238804@main): <https://commits.webkit.org/238804@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431382 [details].
<rdar://problem/79324756>