RESOLVED FIXED 226857
Fix some inefficient uses of SharedBuffer 
https://bugs.webkit.org/show_bug.cgi?id=226857
Summary Fix some inefficient uses of SharedBuffer
Chris Dumez
Reported 2021-06-09 16:19:02 PDT
Fix some inefficient uses of SharedBuffer.
Attachments
Patch (50.15 KB, patch)
2021-06-09 16:26 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (50.16 KB, patch)
2021-06-09 16:48 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (50.16 KB, patch)
2021-06-09 16:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (54.55 KB, patch)
2021-06-09 19:16 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (54.55 KB, patch)
2021-06-09 19:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-06-09 16:26:18 PDT
Created attachment 431023 [details] Patch
Chris Dumez
Comment 2 2021-06-09 16:48:59 PDT
Created attachment 431024 [details] Patch
Chris Dumez
Comment 3 2021-06-09 16:55:31 PDT
Created attachment 431025 [details] Patch
Darin Adler
Comment 4 2021-06-09 18:22:24 PDT
Comment on attachment 431025 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431025&action=review > Source/WebCore/platform/SharedBuffer.h:103 > + Vector<uint8_t> dataAsVector() { return { data(), size() }; } This should have the word "copy" in its name. > Source/WebCore/platform/SharedBuffer.h:188 > + void forEachSegment(const Function<void(const uint8_t*, size_t)>&) const; This should use a Span as the argument. > Source/WebCore/platform/SharedBuffer.h:189 > + bool startsWith(const uint8_t* prefix, size_t prefixSize) const; This should use a Span as the argument.
Chris Dumez
Comment 5 2021-06-09 19:16:11 PDT
Created attachment 431041 [details] Patch
Chris Dumez
Comment 6 2021-06-09 19:29:30 PDT
Created attachment 431042 [details] Patch
EWS
Comment 7 2021-06-09 23:37:41 PDT
Found 1 new test failure: imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html
EWS
Comment 8 2021-06-10 08:08:24 PDT
Committed r278702 (238674@main): <https://commits.webkit.org/238674@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431042 [details].
Radar WebKit Bug Importer
Comment 9 2021-06-10 08:09:18 PDT
<rdar://problem/79140035>
Note You need to log in before you can comment on or make changes to this bug.