Bug 226844 - Create SPI file for Synapse so external builds will work.
Summary: Create SPI file for Synapse so external builds will work.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-09 13:25 PDT by Megan Gardner
Modified: 2021-06-09 21:42 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.42 KB, patch)
2021-06-09 13:30 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (7.37 KB, patch)
2021-06-09 13:38 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (7.37 KB, patch)
2021-06-09 17:32 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2021-06-09 13:25:59 PDT 
Create SPI file for Synapse so external builds will work.
Comment 1 Megan Gardner 2021-06-09 13:30:04 PDT 
Created attachment 431001 [details]
Patch
Comment 2 Tim Horton 2021-06-09 13:32:25 PDT 
Comment on attachment 431001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431001&action=review

> Source/WebKit/Platform/spi/Cocoa/SynapseSPI.h:28
> +#if ENABLE(APP_HIGHLIGHTS)

Maybe this should be around the whole file?

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:6
> -	objectVersion = 52;
> +	objectVersion = 54;

Maybe revert this?
Comment 3 Megan Gardner 2021-06-09 13:38:13 PDT 
Created attachment 431003 [details]
Patch
Comment 4 Megan Gardner 2021-06-09 17:32:44 PDT 
Created attachment 431032 [details]
Patch for landing
Comment 5 EWS 2021-06-09 21:41:52 PDT 
Committed r278691 (238665@main): <https://commits.webkit.org/238665@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431032 [details].
Comment 6 Radar WebKit Bug Importer 2021-06-09 21:42:17 PDT 
<rdar://problem/79119805>