Bug 226843 – [LayoutTests] Delete unused LayoutTests/webaudio resources

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Robert Jenner]

There are a number of unused resources in LayoutTests/webaudio, we should delete them.

[Radar WebKit Bug Importer]

<rdar://problem/79093818>

[Robert Jenner]

Created attachment 430999 [details]
Patch

[Jonathan Bedard]

Comment on attachment 430999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430999&action=review

> LayoutTests/ChangeLog:8
> +        Delete unused php resources after tests were converted to python. 

These don't look like PHP resources, just look like normal resources, no?

[Robert Jenner]

To clarify, this applies to all un-used resources, not just php. Also, with the patch above, it say's the test "media/modern-media-controls/overflow-support/chapters.html" is a "new failure." However, when looking at the history for it, it's a clear indication that this test has been having timeout issues before this patch has even been committed to the project seen here: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Foverflow-support%2Fchapters.html

So, with all of that in mind, I think this is safe to flip to r?

[Jonathan Bedard]

Comment on attachment 430999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430999&action=review

>> LayoutTests/ChangeLog:8
>> +        Delete unused php resources after tests were converted to python. 
> 
> These don't look like PHP resources, just look like normal resources, no?

Let's update the comment to be accurate

> LayoutTests/webaudio/resources/hrtf/README:-4
> -

We should put this file back, it's not used, but it is a README referencing files that are used

[Robert Jenner]

Created attachment 431115 [details]
Patch

[EWS]

Committed r278796 (238753@main): <https://commits.webkit.org/238753@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431115 [details].