Bug 226842 - [LayoutTests] Delete unused LayoutTests/tiled-drawing resources
Summary: [LayoutTests] Delete unused LayoutTests/tiled-drawing resources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Jenner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-09 12:54 PDT by Robert Jenner
Modified: 2021-06-11 16:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.58 KB, patch)
2021-06-09 12:56 PDT, Robert Jenner
no flags Details | Formatted Diff | Diff
Patch (5.70 KB, patch)
2021-06-10 11:47 PDT, Robert Jenner
no flags Details | Formatted Diff | Diff
Patch (5.47 KB, patch)
2021-06-10 12:43 PDT, Robert Jenner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2021-06-09 12:54:07 PDT
There are a number of unused resources in LayoutTests/tiled-drawing, we should delete them.
Comment 1 Radar WebKit Bug Importer 2021-06-09 12:54:46 PDT
<rdar://problem/79093409>
Comment 2 Robert Jenner 2021-06-09 12:56:15 PDT
Created attachment 430997 [details]
Patch
Comment 3 Jonathan Bedard 2021-06-09 13:12:53 PDT
Comment on attachment 430997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430997&action=review

> LayoutTests/ChangeLog:8
> +        Delete unused php resources after tests were converted to python.

This doesn't look like a PHP resource, looks like a normal resource, no?
Comment 4 Robert Jenner 2021-06-10 10:38:48 PDT
To clarify, this applies to all un-used resources, not just php. I was initially under the impression that this was only to remove unused php resources, but the script actually removed all un-used resources. 

For this one, the patch looks good, so I will r? it.
Comment 5 Jonathan Bedard 2021-06-10 10:42:18 PDT
Comment on attachment 430997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430997&action=review

>> LayoutTests/ChangeLog:8
>> +        Delete unused php resources after tests were converted to python.
> 
> This doesn't look like a PHP resource, looks like a normal resource, no?

Let's remove this comment
Comment 6 Robert Jenner 2021-06-10 11:47:49 PDT
Created attachment 431102 [details]
Patch
Comment 7 Robert Jenner 2021-06-10 12:43:55 PDT
Created attachment 431110 [details]
Patch
Comment 8 EWS 2021-06-11 16:39:30 PDT
Committed r278795 (238752@main): <https://commits.webkit.org/238752@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431110 [details].