Bug 226840 - [CMake] Make ANGLE library types configurable
Summary: [CMake] Make ANGLE library types configurable
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
Depends on:
Reported: 2021-06-09 12:47 PDT by Don Olmstead
Modified: 2021-06-10 13:17 PDT (History)
9 users (show)

See Also:

WIP Patch (6.07 KB, patch)
2021-06-09 12:57 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch (6.38 KB, patch)
2021-06-09 15:53 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-06-09 12:47:04 PDT
Windows ports for sure want shared libraries but other ports may not want that.
Comment 1 Don Olmstead 2021-06-09 12:57:22 PDT
Created attachment 430998 [details]
WIP Patch
Comment 2 EWS Watchlist 2021-06-09 12:58:55 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Don Olmstead 2021-06-09 15:53:17 PDT
Created attachment 431021 [details]
Comment 4 Kenneth Russell 2021-06-09 16:00:38 PDT
Comment on attachment 431021 [details]

If everything builds, looks good to me! r+
Comment 5 Eleni Maria Stea 2021-06-09 23:04:24 PDT
Thanks a lot! It looks good to me (+r) but I need to modify a little bit the GTK port (WIP).
Comment 6 EWS 2021-06-10 13:17:26 PDT
Committed r278726 (238689@main): <https://commits.webkit.org/238689@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431021 [details].