Bug 226823 - Scrollbars are not clipped to layer bounds in RenderLayerBacking
Summary: Scrollbars are not clipped to layer bounds in RenderLayerBacking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords: InRadar
Depends on:
Blocks: 224596
  Show dependency tree / graph
 
Reported: 2021-06-09 09:15 PDT by Chris Lord
Modified: 2021-06-16 00:47 PDT (History)
15 users (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2021-06-09 09:18 PDT, Chris Lord 		no flags Details | Formatted Diff | Diff
Patch (2.17 KB, patch)
2021-06-14 08:40 PDT, Chris Lord 		no flags Details | Formatted Diff | Diff
Patch (25.19 KB, patch)
2021-06-15 03:26 PDT, Chris Lord 		no flags Details | Formatted Diff | Diff
Patch (26.37 KB, patch)
2021-06-15 04:04 PDT, Chris Lord 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2021-06-09 09:15:42 PDT 
As in the summary - perhaps it's intentional that scrollbars can appear outside of the content they correspond to, but this is causing some tests to fail with async overflow scroll enabled; namely imported/w3c/web-platform-tests/css/css-flexbox/overflow-auto-001.html (and perhaps more that we'll find out via EWS/bots if this lands)
Comment 1 Chris Lord 2021-06-09 09:18:00 PDT 
Created attachment 430970 [details]
Patch
Comment 2 Chris Lord 2021-06-14 08:40:19 PDT 
Created attachment 431325 [details]
Patch
Comment 3 Chris Lord 2021-06-14 09:15:50 PDT 
Comment on attachment 431325 [details]
Patch

The 1 failure on Mac is because the expectations don't expect the overflow container layer to clip its children (which is what this patch modifies) - assuming the approach is deemed correct, I'll modify the expectations.
Comment 4 Chris Lord 2021-06-15 03:26:47 PDT 
Created attachment 431419 [details]
Patch
Comment 5 Chris Lord 2021-06-15 04:04:23 PDT 
Created attachment 431420 [details]
Patch
Comment 6 Chris Lord 2021-06-15 06:13:42 PDT 
Comment on attachment 431420 [details]
Patch

Added a test for this in compositing/scrolling/async-overflow-scrolling as the only test that was hitting this was in WPT.
Comment 7 EWS 2021-06-15 11:12:41 PDT 
Committed r278883 (238825@main): <https://commits.webkit.org/238825@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431420 [details].
Comment 8 Radar WebKit Bug Importer 2021-06-15 11:13:20 PDT 
<rdar://problem/79351898>