Bug 226805 - Clean up scrollbar creation code in RenderLayerScrollableArea
Summary: Clean up scrollbar creation code in RenderLayerScrollableArea
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-08 21:55 PDT by Simon Fraser (smfr)
Modified: 2021-06-09 09:56 PDT (History)
12 users (show)

See Also:

Attachments
Patch (14.91 KB, patch)
2021-06-08 21:57 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-06-08 21:55:55 PDT 
Clean up scrollbar creation code in RenderLayerScrollableArea
Comment 1 Simon Fraser (smfr) 2021-06-08 21:57:50 PDT 
Created attachment 430940 [details]
Patch
Comment 2 zalan 2021-06-09 06:52:44 PDT 
Comment on attachment 430940 [details]
Patch

Sometimes the nullopt value of optional<bool> puzzles me. It's not too bad here though.
Comment 3 EWS 2021-06-09 09:02:30 PDT 
Committed r278661 (238643@main): <https://commits.webkit.org/238643@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430940 [details].
Comment 4 Radar WebKit Bug Importer 2021-06-09 09:03:20 PDT 
<rdar://problem/79079650>
Comment 5 Alex Christensen 2021-06-09 09:47:47 PDT 
This seems to have broken the Windows build.
https://ews-build.webkit.org/#/builders/10/builds/95353
Comment 6 Simon Fraser (smfr) 2021-06-09 09:54:20 PDT 
Fixing
Comment 7 Simon Fraser (smfr) 2021-06-09 09:56:09 PDT 
Fixed in r278664.