Bug 226788 - Rely on SQLiteDatabase::setMaximumSize() for quota management in LocalStorageDatabase
Summary: Rely on SQLiteDatabase::setMaximumSize() for quota management in LocalStorage...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
: 226814 (view as bug list)
Depends on:
Blocks: 226832
  Show dependency treegraph
Reported: 2021-06-08 16:21 PDT by Chris Dumez
Modified: 2021-06-16 08:44 PDT (History)
6 users (show)

See Also:

Patch (5.98 KB, patch)
2021-06-08 16:23 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-06-08 16:21:45 PDT
Rely on SQLiteDatabase::setMaximumSize() for quota management in LocalStorageDatabase. It simplifies the code a bit.
Comment 1 Chris Dumez 2021-06-08 16:23:39 PDT
Created attachment 430907 [details]
Comment 2 Kimmo Kinnunen 2021-06-08 22:33:06 PDT
Comment on attachment 430907 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=430907&action=review

looks good as far as I understand the part (which is not terribly much)

> Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp:232
> +        if (result == SQLITE_FULL)

(Not specific to this patch, but I'd imagine this can happen in other operations too, such as the removeItem above.)
Comment 3 EWS 2021-06-09 00:02:48 PDT
Committed r278651 (238633@main): <https://commits.webkit.org/238633@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430907 [details].
Comment 4 Radar WebKit Bug Importer 2021-06-09 00:03:16 PDT
Comment 5 Chris Dumez 2021-06-16 08:44:18 PDT
*** Bug 226814 has been marked as a duplicate of this bug. ***