Bug 22677 - WebKitTools/Scripts/build-webkit --video doesn't work for Qt port
Summary: WebKitTools/Scripts/build-webkit --video doesn't work for Qt port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-05 02:23 PST by Bernhard Rosenkraenzer
Modified: 2009-09-07 10:09 PDT (History)
1 user (show)

See Also:


Attachments
Patch to fix Phonon includes (446 bytes, patch)
2009-07-12 14:31 PDT, Chris Hills
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Rosenkraenzer 2008-12-05 02:23:20 PST
Building the Qt port with --video doesn't actually provide video support -- but video support for the Qt port is implemented (enabled when WebKit is built inside the Qt source).

From a quick look at the Makefiles, I think --video should set QT_CONFIG += phonon for the qt build.
Comment 1 Chris Hills 2009-07-12 14:31:44 PDT
Created attachment 32634 [details]
Patch to fix Phonon includes

The problem is that there is no such path $QTDIR/include/Phonon in a vanilla Qt installation. This patch removes "Phonon/" since the proper phonon include path is already applied by qmake.
Comment 2 Tor Arne Vestbø 2009-09-07 10:09:36 PDT
Landed in r48122